Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(env-vars): config, webhooks and gateway env validation #7625

Merged
merged 14 commits into from
Oct 2, 2024

Conversation

naftis
Copy link
Collaborator

@naftis naftis commented Sep 18, 2024

#5932

Refactors config, gateway and webhooks to use envalid and enforce setting environment variables in production. I added these to same PR as they depend on a validateFunc -function in commons.

Copy link

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

@naftis naftis changed the title refactor(env-vars): config refactor(env-vars): config environment validation Sep 18, 2024
@naftis naftis added this to the v1.7.0 milestone Sep 18, 2024
@naftis naftis changed the base branch from ocrvs-5932-auth to develop September 18, 2024 10:43
@naftis
Copy link
Collaborator Author

naftis commented Sep 18, 2024

Gateway, config and webhooks use the "validateFunc" so they should be done in this same PR.

@naftis naftis changed the title refactor(env-vars): config environment validation refactor(env-vars): config, webhooks and gateway env validation Sep 18, 2024
@ocrvs-bot
Copy link
Collaborator

Your environment is deployed to https://ocrvs-5932-config.opencrvs.dev.

@naftis naftis merged commit 786e0ba into develop Oct 2, 2024
38 of 39 checks passed
@naftis naftis deleted the ocrvs-5932-config branch October 2, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants